chore: replace redundant useManagedState with Vue's defineModel #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6d29d4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoCa96
force-pushed
the
joca96/remove-managed-state
branch
3 times, most recently
from
42ee9e0 to
7deab1a
Compare
JoCa96
changed the title
larsrickert
requested changes
Jan 17, 2025
packages/sit-onyx/src/components/OnyxMiniSearch/OnyxMiniSearch.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/examples/FormExample/FormExample.vue
Outdated
Show resolved
Hide resolved
JoCa96
force-pushed
the
joca96/remove-managed-state
branch
from
a77be86 to
77d2951
Compare
larsrickert
requested changes
Jan 17, 2025
JoCa96
force-pushed
the
joca96/remove-managed-state
branch
from
6138353 to
21148a0
Compare
JoCa96
force-pushed
the
joca96/remove-managed-state
branch
from
21148a0 to
725f854
Compare
larsrickert
approved these changes
Jan 21, 2025
JoCa96
added a commit
that referenced
this pull request
Jan 30, 2025
The changes are mostly internal, but the typings were of `OnyxSelect` have changed: - The `modelValue` now infers a specific subtype of `SelectOptionValue` and the `options` values must match. - `withSearch`: Filtering of the options will not automatically disabled anymore when `searchTerm` is bound. Instead `noFilter` must be set. - removed `Arrayable` type, imported from `vitest`, as it was an internal type. Replaced with our own type with the same name. - removed redundant `MaybeReactiveSource` type, as it is now covered by Vue's `MaybeRefOrGetter` type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are mostly internal, but the typings were of
OnyxSelecthave changed:modelValuenow infers a specific subtype ofSelectOptionValueand theoptionsvalues must match.withSearch: Filtering of the options will not automatically disabled anymore whensearchTermis bound. InsteadnoFiltermust be set.Arrayabletype, imported fromvitest, as it was an internal type. Replaced with our own type with the same name.MaybeReactiveSourcetype, as it is now covered by Vue'sMaybeRefOrGettertype